Re: Doesn't pgstat_report_wal() handle the argument "force" incorrectly
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Ryoga Yoshida <bt23yoshidar@oss.nttdata.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-09-26T00:33:23Z
Lists: pgsql-hackers
On Mon, Sep 25, 2023 at 02:49:50PM +0900, Ryoga Yoshida wrote: > On 2023-09-25 14:38, Michael Paquier wrote: >> Another idea would be to do like in pgstat.c by adding the following >> line, then use "nowait" to call each sub-function: >> nowait = !force; >> pgstat_flush_wal(nowait); >> pgstat_flush_io(nowait); > > That's very clear and I think it's good. Done this way down to 15, then, with more comment polishing. -- Michael
Commits
-
Fix behavior of "force" in pgstat_report_wal()
- 802fcb9ed166 15.5 landed
- 280f70221ba5 16.1 landed
- e221c0befb1b 17.0 landed