Re: GUC for temporarily disabling event triggers
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>, Mikhail Gribkov <youzhick@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2023-09-24T23:35:41Z
Lists: pgsql-hackers
Attachments
- v9-0001-Add-GUC-for-temporarily-disabling-event-triggers.patch (text/x-diff) patch v9-0001
- v9-0002-Fix-failure-in-TAP-tests.patch (text/x-diff) patch v9-0002
On Fri, Sep 22, 2023 at 05:29:01PM +0200, Daniel Gustafsson wrote: > Since the main driver for this is to reduce the usage/need for single-user mode > I also reworded the patch slightly. Instead of phrasing this as an alternative > to single-user mode, I reversed it such that single-user mode is an alternative > to this GUC. Okay. + be disabled by setting it to <literal>false</literal>. Setting the value + to <literal>true</literal> will not disable any event triggers, this This uses a double negation. Perhaps just "Setting this value to true allows all event triggers to run." 003_check_guc.pl has detected a failure because event_triggers is missing in postgresql.conf.sample while it is not marked with GUC_NOT_IN_SAMPLE anymore. Keeping the docs consistent with the sample file, I would suggest the attached on top of your v9. -- Michael
Commits
-
Add GUC for temporarily disabling event triggers
- 7750fefdb2b8 17.0 landed
-
Fix typos in code and comments
- 5f6401f81cb2 16.0 cited