Horton

Re: Bug fix in vacuumdb --buffer-usage-limit xxx -Z

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Ryoga Yoshida <bt23yoshidar@oss.nttdata.com>, pgsql-hackers@lists.postgresql.org
Date: 2023-09-22T05:21:46Z
Lists: pgsql-hackers

Attachments

On Thu, Sep 21, 2023 at 06:56:29PM +1200, David Rowley wrote:
> I deem it pretty unlikely that someone will accidentally remove the
> code that I just committed and a test to test that vacuumdb -Z
> --buffer-usage-limit ... passes the BUFFER_USAGE_LIMIT option would
> likely just forever mark that we once had a trivial bug that forgot to
> include the --buffer-usage-limit when -Z was specified.

Perhaps so.

> If others feel strongly that a test is worthwhile, then I'll reconsider.

I don't know if you would like that, but the addition is as simple as
the attached, FYI.
--
Michael

Commits

  1. Fix vacuumdb to pass buffer-usage-limit with analyze-only mode