Horton
Menu

Re: pg_basebackup: Always return valid temporary slot names

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jelte Fennema <me@jeltef.nl>, Nishant Sharma <nishant.sharma@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Jim Jones <jim.jones@uni-muenster.de>
Date: 2023-09-07T04:28:46Z
Lists: pgsql-hackers 
On Thu, Sep 07, 2023 at 01:23:33PM +0900, Michael Paquier wrote:
> PQbackendPID() returns a signed value, likely coming from the fact
> that it was thought to be OK back in the days where PIDs were always
> defined with less bits.  The fix is OK taken in isolation, so I am
> going to apply it in a few minutes as I'm just passing by..

Actually, correcting myself, pid_max cannot be higher than 2^22 on 64b
machines even these days (per man 5 proc).
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_basebackup: Generate valid temporary slot names under PQbackendPID()