Re: sync_standbys_defined read/write race on startup

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: "Maksim.Melnikov" <m.melnikov@postgrespro.ru>

Cc: Kirill Reshke <reshkekirill@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2025-04-11T01:10:46Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix race with synchronous_standby_names at startup
- e2f42f812a80 13.21 landed
- 873aff945a7b 14.18 landed
- ec59500a1740 15.13 landed
- c922ae2c42a6 16.9 landed
- 3339847ccde0 17.5 landed
- 2e57790836c6 18.0 landed

On Thu, Apr 10, 2025 at 12:55:54PM +0300, Maksim.Melnikov wrote:
> On 10.04.2025 12:15, Michael Paquier wrote:
>> Hmm, yeah.  Instead of last, it would be better to put it in second
>> place perhaps, for clarity?  That would be the same at the end, but we
>> would be slightly more consistent with the past logic regarding the
>> ordering.  Does that look OK to you?
> 
> Yes, from my point of view it looks fine.

Thanks for the double-check.  I've played a couple more hours with the
startup case, like playing with s_s_names set but uninitialized in
shmem while stucking backends, and that seems OK, so applied down to
v13.  Let's see how it goes..
--
Michael