Horton

Re: Add pg_get_injection_points() for information of injection points

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-14T12:32:29Z
Lists: pgsql-hackers 
On Mon, Apr 14, 2025 at 05:26:14PM +0500, Kirill Reshke wrote:
> Hi! I noticed you do not bump catalog version here, so i was a little
> confused with
> ```
> reshke=# SELECT name, library, function FROM pg_get_injection_points();
> ERROR:  function pg_get_injection_points() does not exist
> ```
> for a while

Catalog version bumps are done by committers when code is committed.
When sending patches for reviews (this one is for July and v19),
including catversion bumps in the patches sent just leads to useless
code conflicts, so this should not be done when submitting something.

> Also, should we define pg_get_injection_points in the injection_points
> extension maybe?

As this is global for all libraries, that's not something I would add
there.
--
Michael

Commits

  1. injection_points: Add injection_points_list()

  2. Add InjectionPointList() to retrieve list of injection points