Horton

Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jacob Champion <jchampion@timescale.com>, Tobias Bussmann <t.bussmann@gmx.net>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Mark Guertin <markguertin@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2023-07-20T23:53:02Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Skip .DS_Store files in server side utils

On Thu, Jul 20, 2023 at 12:36:52PM +0200, Daniel Gustafsson wrote:
> On 20 Jul 2023, at 09:47, Michael Paquier <michael@paquier.xyz> wrote:
>> Hmm.  Are you sure that this is correct for pg_rewind?  This should
>> work when using a local source with --source-pgdata, but under a
>> remote source with --source-pgdata, I get the impression that we'd
>> still copy a .DS_store into the target's data folder.
> 
> Ah, good point.  The updated patch should work for both by moving the check
> into the filemap.

Sounds OK to me to do that in the filemap.  The checksum and base
backup parts look OK as well.  Thanks for the quick update!
--
Michael