Horton

ObjectIdGetDatum() missing from SearchSysCache*() callers

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-07-17T11:10:34Z
Lists: pgsql-hackers

Attachments

Hi all,

While scanning the code, I have noticed that a couple of code paths
that do syscache lookups are passing down directly Oids rather than
Datums.  I think that we'd better be consistent here, even if there is
no actual bug.

I have noticed 11 callers of SearchSysCache*() that pass down
an Oid instead of a Datum.

Thoughts or comments?
--
Michael

Commits

  1. Add missing ObjectIdGetDatum() in syscache lookup calls for Oids