Re: Support worker_spi to execute the function dynamically.
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Masahiro Ikeda <ikedamsh@oss.nttdata.com>, pgsql-hackers@lists.postgresql.org
Date: 2023-07-24T08:38:45Z
Lists: pgsql-hackers
On Mon, Jul 24, 2023 at 01:50:45PM +0530, Bharath Rupireddy wrote: > I disagree with removing SQL tests from the worker_spi module. As said > upthread, it makes the worker_spi a fully demonstrable > extension/module - one can just take it, start adding required > functionality and test-cases (both SQL and TAP) for a new module. Which is basically the same thing with TAP except that these are grouped now? The value of a few raw SQL queries with a NO_INSTALLCHECK does not strike me as enough on top of having to maintain two different sets of tests. I'd still choose the cheap and extensible path here. > I agree that moving to TAP tests will reduce test run time by 1.9 > seconds, but to me personally this is not an optimization we must be > doing at the expense of demonstrability. In a large parallel run, the difference can be felt. -- Michael
Commits
-
worker_spi: Fix race condition in newly-added TAP tests
- b68e356a680e 17.0 landed
-
worker_spi: Switch to TAP tests
- 320c311fda91 17.0 landed
-
worker_spi: Use term "dynamic" for bgworkers launched with worker_spi_launch()
- d9eb92c7b122 17.0 landed
-
Fix worker_spi when launching workers without shared_preload_libraries
- 97ff8dd02ca7 17.0 landed