Horton

Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jacob Champion <jchampion@timescale.com>, Peter Eisentraut <peter@eisentraut.org>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Andrew Dunstan <andrew@dunslane.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-07-03T01:17:24Z
Lists: pgsql-hackers 
On Fri, Jun 30, 2023 at 09:42:13AM +0200, Daniel Gustafsson wrote:
> Agreed, I'd prefer all branches to work the same for this.

Thanks, done this way across all the branches, then.

> Reading the patch, only one thing stood out:
> 
> -variable PG_TEST_NOCLEAN is set, data directories will be retained
> -regardless of test status.
> +variable PG_TEST_NOCLEAN is set, those directories will be retained
> 
> I would've written "the data directories" instead of "those directories" here.

Adjusted that as well, on top of an extra comment.
--
Michael

Commits

  1. Make PG_TEST_NOCLEAN work for temporary directories in TAP tests