Horton

Re: Deleting prepared statements from libpq.

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Jelte Fennema <me@jeltef.nl>
Cc: jian he <jian.universality@gmail.com>, Dmitry Igrishin <dmitigr@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Daniele Varrazzo <daniele.varrazzo@gmail.com>
Date: 2023-06-20T04:18:36Z
Lists: pgsql-hackers 
On Mon, Jun 19, 2023 at 02:49:44PM +0200, Jelte Fennema wrote:
> On Mon, 19 Jun 2023 at 14:17, jian he <jian.universality@gmail.com> wrote:
>> I am not sure the following two following function comments are right....
> 
> They were incorrect indeed. Attached is a patch with those two updated.

The amount of duplication between the describe and close paths
concerns me a bit.  Should PQsendClose() and PQsendDescribe() be
merged into a single routine (say PQsendCommand), that uses a message
type for pqPutMsgStart and a queryclass as extra arguments?
--
Michael

Commits

  1. libpq: Add support for Close on portals and statements

  2. Fix incorrect error message in libpq_pipeline