Horton

Re: Another incorrect comment for pg_stat_statements

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Japin Li <japinli@hotmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-06-28T07:04:48Z
Lists: pgsql-hackers 
On Wed, Jun 28, 2023 at 12:15:47PM +0800, Japin Li wrote:
> -		/* Remove the key if it exists, starting with the top-level entry  */
> +		/* Remove the key if it exists, starting with the non-top-level entry */
>  		key.toplevel = false;
>  		entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL);
>  		if (entry)				/* found */

Nice catch.  That's indeed wrong.  Will fix.
--
Michael

Commits

  1. pg_stat_statements: Fix second comment related to entry resets

  2. pg_stat_statements: Fix incorrect comment with entry resets

  3. Track identical top vs nested queries independently in pg_stat_statements