Horton

Re: Add TLI number to name of files generated by pg_waldump --save-fullpage

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, masao.fujii@gmail.com, david.christensen@crunchydata.com
Date: 2023-06-27T23:47:21Z
Lists: pgsql-hackers

Attachments

On Tue, Jun 27, 2023 at 04:39:52PM +0900, Kyotaro Horiguchi wrote:
> I meant that the name is structured as
> TLIh-TLIl.<tablespace>.<database>.<relnumber>.<blk>._<fork>, which
> appears to be inconsistent with the comment. (And I'm not sure what
> "TLOID" is..)

Well, to be clear, it should not be TLIh-TLIl but LSNh-LSNl :)

I'm OK with these terms for the comments.  This is very internal
anyway so anybody using this feature should know what that means.

And yes, the order of the items is wrong, and I agree that TLOID is a
bit confusing once the TLI is added in the set.  I have just used
TBLSPCOID as term in the comment, and adjusted the XXX to be about the
LSN numbers.

Adjusted as per the v2 attached.
--
Michael

Commits

  1. Add timeline ID to file names generated with pg_waldump --save-fullpage