Horton

Re: v16 fails to build w/ Visual Studio 2015

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>, pgsql-hackers@postgresql.org
Date: 2023-06-12T00:40:52Z
Lists: pgsql-hackers 
On Wed, Jun 07, 2023 at 11:35:34PM +0200, Peter Eisentraut wrote:
> I kind of like the style where there is only one return at the end, because
> it makes it easier to inject debugging code that inspects the return value.

I kind of disagree here, the previous style is a bit ugly-ish, with
the code generated by gen_node_support.pl being dependent on this
local call because it is necessary to know about return_value:
-   if (false)
-       ;
 #include "readfuncs.switch.c"

So +1 for what's proposed.
--
Michael

Commits

  1. Make parseNodeString() C idiom compatible with Visual Studio 2015.

  2. Automatically generate node support functions