Re: 回复:Fix missing initialization of delayChkptEnd

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: mengjuan.cmj@alibaba-inc.com, pgsql-hackers@lists.postgresql.org, robertmhaas@gmail.com
Date: 2023-06-06T11:19:12Z
Lists: pgsql-hackers
On Tue, Jun 06, 2023 at 03:13:14PM +0900, Kyotaro Horiguchi wrote:
> After a quick check through the 14 tree, then compaing with the
> corresponding parts of 15, it hit me that ProcArrayClearTransaction()
> needs an assertion on the variable.  Other than that, the patch looks
> good to me.

Yeah, it feels wrong to check only after delayChkpt in this code
path.  I'll look at that tomorrow.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Fix missing initializations of MyProc.delayChkptEnd

  2. Rethink the delay-checkpoint-end mechanism in the back-branches.