Re: Naming of gss_accept_deleg
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Abhijit Menon-Sen <ams@toroid.org>, Stephen Frost <sfrost@snowman.net>, pgsql-hackers@postgresql.org
Date: 2023-05-21T03:27:29Z
Lists: pgsql-hackers
On Sat, May 20, 2023 at 11:21:57PM -0400, Tom Lane wrote: > Nathan Bossart <nathandbossart@gmail.com> writes: > > On Sat, May 20, 2023 at 09:33:44PM -0400, Bruce Momjian wrote: > >> With less then 48 hours to beta 1 packaging, I have made this change and > >> adjusted internal variable to match. > > > The buildfarm and cfbot seem unhappy with 9c0a0e2. It looks like there are > > a few remaining uses of gss_accept_deleg to rename. I'm planning to commit > > the attached patch shortly. > > I thought the plan was to also rename the libpq "gssdeleg" connection > parameter and so on? I can look into that tomorrow, if nobody beats > me to it. Oh, I didn't consider those. I thought we would leave libpq alone since those are often supplied on the command line and there are existing short-style libpq options, e.g., gssencmode, krbsrvname, sslcrl. I am fine with such a change though. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.
Commits
-
Spell the values of libpq's gssdelegation parameter as "0" and "1".
- 1f9f6aa49198 16.0 landed
-
Expand some more uses of "deleg" to "delegation" or "delegated".
- a2eb99a01e01 16.0 landed
-
Fix remaining references to gss_accept_deleg.
- f4001a553770 16.0 landed
-
rename "gss_accept_deleg" to "gss_accept_delegation".
- 9c0a0e2ed92a 16.0 landed