Re: Naming of gss_accept_deleg

Abhijit Menon-Sen <ams@toroid.org>

From: Abhijit Menon-Sen <ams@toroid.org>
To: Bruce Momjian <bruce@momjian.us>
Cc: Stephen Frost <sfrost@snowman.net>, pgsql-hackers@postgresql.org
Date: 2023-05-19T13:35:19Z
Lists: pgsql-hackers
At 2023-05-19 09:16:09 -0400, bruce@momjian.us wrote:
>
> On Fri, May 19, 2023 at 09:07:26AM -0400, Stephen Frost wrote:
> > 
> > > Why is the new PG 16 GUC called "gss_accept_deleg" and not
> > > "gss_accept_delegation"?  The abbreviation here seems atypical.
> > 
> > At the time it felt natural to me but I don't feel strongly about it,
> > happy to change it if folks would prefer it spelled out.
> 
> Yes, please do spell it out, thanks.  The fact "deleg" looks similar to
> "debug" also doesn't help.

Note that GSS-API itself calls it the "DELEG" flag:

    if (conn->gcred != GSS_C_NO_CREDENTIAL)
            gss_flags |= GSS_C_DELEG_FLAG;

I would also prefer a GUC named gss_accept_delegation, but the current
name matches the libpq gssdeleg connection parameter and the PGSSDELEG
environment variable. Maybe there's something to be said for keeping
those three things alike?

-- Abhijit



Commits

  1. Spell the values of libpq's gssdelegation parameter as "0" and "1".

  2. Expand some more uses of "deleg" to "delegation" or "delegated".

  3. Fix remaining references to gss_accept_deleg.

  4. rename "gss_accept_deleg" to "gss_accept_delegation".