Horton

Re: Naming of gss_accept_deleg

Abhijit Menon-Sen <ams@toroid.org>

View thread View on postgr.es
From: Abhijit Menon-Sen <ams@toroid.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Stephen Frost <sfrost@snowman.net>, Nathan Bossart <nathandbossart@gmail.com>, Bruce Momjian <bruce@momjian.us>, pgsql-hackers@postgresql.org
Date: 2023-05-22T13:44:40Z
Lists: pgsql-hackers 
At 2023-05-22 09:42:44 -0400, tgl@sss.pgh.pa.us wrote:
>
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > I noticed that the value that enables this feature at libpq client side
> > is 'enable'.  However, for other Boolean settings like sslsni,
> > keepalives, requiressl, sslcompression, the value that enables feature
> > is '1' -- we use strings only for "enum" type of settings.
> 
> > Also, it looks like connectOptions2() doesn't validate the string value.
> 
> Hmm, it certainly seems like this ought to accept exactly the
> same inputs as other libpq boolean settings.  I can take a look
> unless somebody else is already on it.

I'm working on it.

-- Abhijit

Commits

  1. Spell the values of libpq's gssdelegation parameter as "0" and "1".

  2. Expand some more uses of "deleg" to "delegation" or "delegated".

  3. Fix remaining references to gss_accept_deleg.

  4. rename "gss_accept_deleg" to "gss_accept_delegation".