Re: MERGE lacks ruleutils.c decompiling support!?
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers@lists.postgresql.org
Date: 2023-05-06T02:46:06Z
Lists: pgsql-hackers
On Fri, May 05, 2023 at 05:06:34PM -0400, Tom Lane wrote: > I did a bit of review and more work on this: > > * Added the missing OVERRIDING support > > * Played around with the pretty-printing indentation > > * Improved test coverage, and moved the test to rules.sql where > I thought it fit more naturally. > > I think we could probably commit this, though I've not tried it > in v15 yet. Seems rather OK.. +WHEN NOT MATCHED + AND s.a > 100 + THEN INSERT (id, data) OVERRIDING SYSTEM VALUE + VALUES (s.a, DEFAULT) About OVERRIDING, I can see that this is still missing coverage for OVERRIDING USER VALUE. -- Michael
Commits
-
Add ruleutils support for decompiling MERGE commands.
- f200b9695fde 15.3 landed
- 41e2c52fd6eb 16.0 landed