Horton

Re: Autogenerate some wait events code and documentation

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-20T00:48:08Z
Lists: pgsql-hackers 
On Thu, Mar 30, 2023 at 12:41:27PM -0400, Corey Huinker wrote:
> I think this is good work, but I can't help thinking it would be easier to
> understand and maintain if we used a template engine like Text::Template,
> and filled out the template with the variant bits. I'll ask that question
> in another thread for higher visibility.

Hmm..  This is not part of the main perl distribution, is it?  I am
not sure that it is a good idea to increase the requirement bar when
it comes to build the code and documentation by depending more on
external modules, and the minimum version of perl supported is very
old^D^D^D ancient, making it harder to satisfy.
--
Michael

Commits

  1. Add "ABI_compatibility" regions to wait_event_names.txt

  2. Remove column for wait event names in wait_event_names.txt

  3. Use more consistent names for wait event objects and types

  4. Add information about line contents on parsing failure of wait_event_names.txt

  5. Remove double quotes from the second column of wait_event_names.txt

  6. Generate automatically code and documentation related to wait events

  7. Refactor some code related to wait events "BufferPin" and "Extension"

  8. doc: Fix ordering of entries in wait event table for I/O type