Re: longfin missing gssapi_ext.h
Stephen Frost <sfrost@snowman.net>
From: Stephen Frost <sfrost@snowman.net>
To: "Jonathan S. Katz" <jkatz@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2023-04-12T01:18:08Z
Lists: pgsql-hackers
Attachments
- gss_delegation_v11.patch (text/x-diff) patch v11
Greetings, * Jonathan S. Katz (jkatz@postgresql.org) wrote: > On 4/10/23 11:37 AM, Tom Lane wrote: > > Stephen Frost <sfrost@snowman.net> writes: > > > * Tom Lane (tgl@sss.pgh.pa.us) wrote: > > > > IOW, maybe it'd be okay to de-revert 3d4fa227b and add documentation > > > > saying that --with-gssapi requires MIT Kerberos not Heimdal. > > > > > I'd be happy with that and can add the appropriate documentation noting > > > that we require MIT Kerberos. Presumably the appropriate step at this > > > point would be to check with the RMT? > > > > Yeah, RMT would have final say at this stage. > > > > If you pull the trigger, a note to buildfarm-members would be > > appropriate too, so people will know if they need to remove > > --with-gssapi from animal configurations. > > The RMT discussed this thread and agrees to a "de-revert" of the "Add > support for Kerberos delegation" patch, provided that: > > 1. The appropriate documentation is added AND > 2. The de-revert occurs no later than 2023-04-15 (upper bound 2023-04-16 > 0:00 AoE). > > There's an open item[1] for this task. Understood. Please find attached the updated patch with changes to the commit message to indicate that we now require MIT Kerberos, an additional explicit check for gssapi_ext.h in configure.ac/configure, along with updated documentation explicitly saying we require MIT Kerberos for GSSAPI support. I'll plan to push this tomorrow. Of course, suggestions/improvements on documentation or anything else always welcome. Thanks all! Stephen
Commits
-
Further cleanup of autoconf output files for GSSAPI changes.
- d48ac0070cff 16.0 landed
-
Update Kerberos/GSSAPI configure/meson check
- 1c52f9c042fb 16.0 landed
-
Explicitly require MIT Kerberos for GSSAPI
- f7431bca8b01 16.0 landed
-
De-Revert "Add support for Kerberos credential delegation"
- 6633cfb21691 16.0 landed
-
Revert "Add support for Kerberos credential delegation"
- 3d03b24c350a 16.0 landed