Horton

Re: pgindent vs. git whitespace check

Bruce Momjian <bruce@momjian.us>

View thread View on postgr.es
From: Bruce Momjian <bruce@momjian.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, John Naylor <john.naylor@enterprisedb.com>, Andrew Dunstan <andrew@dunslane.net>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-03-30T14:48:25Z
Lists: pgsql-hackers 
On Wed, Mar 29, 2023 at 08:26:23PM +0200, Daniel Gustafsson wrote:
> > On 29 Mar 2023, at 19:18, Bruce Momjian <bruce@momjian.us> wrote:
> > We would have to convert all supported branches, and tell all forks to
> > do the same (hopefully at the same time).  The new standard would then
> > be for all single-line comments to use // instead of /* ... */.
> 
> That still leaves every patch which is in flight on -hackers, and conflicts in
> local development trees etc.  It's doable (apart from forks, but that cannot be
> our core concern), but I personally can't see the price paid justify the result.

Yes, this would have to be done at the start of a new release cycle.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Embrace your flaws.  They make you human, rather than perfect,
  which you will never be.

Commits

  1. Fix comment indentation and whitespace