Re: Disable rdns for Kerberos tests
Stephen Frost <sfrost@snowman.net>
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers@lists.postgresql.org
Date: 2023-04-05T16:10:00Z
Lists: pgsql-hackers
Attachments
- krbdns_disable_v1.patch (text/x-diff) patch v1
Greetings, * Tom Lane (tgl@sss.pgh.pa.us) wrote: > Stephen Frost <sfrost@snowman.net> writes: > > Push, thanks again! > > Why'd you only change HEAD? Isn't the test equally fragile in the > back branches? Following on from this after some additional cross-platform testing, turns out there's other options we should be disabling in these tests to avoid depending on DNS for the test. Attached is another patch which, for me at least, seems to prevent the tests from causing any DNS requests to happen. This also means that the tests run in a reasonable time even in cases where DNS is entirely broken (the resolver set in /etc/resolv.conf doesn't respond). Barring objections, my plan is to commit this change soon and to back-patch both patches to supported branches. Thanks! Stephen
Commits
-
For Kerberos testing, disable reverse DNS lookup
- 0787432f33fb 15.3 landed
- 1fdd1fbe10fe 14.8 landed
- cd018a2b3f24 13.11 landed
- 1beb70d81073 12.15 landed
- f0bd3361e09d 11.20 landed
- 8dff2f224f4f 16.0 landed