Re: GUC for temporarily disabling event triggers
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, Mikhail Gribkov <youzhick@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2023-04-05T08:10:32Z
Lists: pgsql-hackers
On Mon, Apr 03, 2023 at 11:35:14PM +0200, Daniel Gustafsson wrote: > Yeah. The patch as it stands allow for disabling specific types rather than > all-or-nothing, which is why the name was "ignore". FWIW, I agree with Robert's points here: - disable_event_triggers or ignore_event_triggers = off leads to a double-negative meaning, which is a positive. Depending on one's native language that can be confusing. - Being able to write a list of event triggers working would be much more interesting than just individual elements. - There may be an argument for negated patterns? Say, a "!sql_drop,!ddl_command_start" would cause sql_drop and ddl_command_start to be disabled with all the others enabled, and one should not ne able to mix negated and non-negated patterns. A few days before the end of the commit fest, perhaps you'd better head towards having only an event_trigger = on | off or all | none and consider expanding that later on? From what I get at the top of the thread, this would satisfy the main use case you seemed to worry about to begin with. -- Michael
Commits
-
Add GUC for temporarily disabling event triggers
- 7750fefdb2b8 17.0 landed
-
Fix typos in code and comments
- 5f6401f81cb2 16.0 cited