Re: Fix fseek() detection of unseekable files on WIN32
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2023-03-22T00:12:36Z
Lists: pgsql-hackers
On Mon, Mar 20, 2023 at 07:06:22AM +0900, Michael Paquier wrote: > Not sure about this one. I have considered it and dirmod.c includes > also bits for cygwin, while being aimed for higher-level routines like > rename(), unlink() or symlink(). This patch is only for WIN32, and > aimed for common parts in win32*.c code, so a separate file seemed a > bit cleaner to me at the end. By the way, do you think that we could be able to get a TAP test for that? It does not seem that it needs to be that complicated, as long as we use a pg_dump command that pipes its output to a pg_restore command launched by system()? -- Michael
Commits
-
Fix detection of unseekable files for fseek() and ftello() with MSVC
- 34105eea62e1 14.8 landed
- 5c32549460fc 15.3 landed
- a923e21631a2 16.0 landed