Horton

Re: Combine pg_walinspect till_end_of_wal functions with others

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Jeff Davis <pgsql@j-davis.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-03-23T02:52:53Z
Lists: pgsql-hackers 
On Thu, Mar 16, 2023 at 01:17:59PM +0530, Bharath Rupireddy wrote:
> FWIW, I rebased the tests tweaking patch and attached it here as v9.
> This should keep the pg_walinspect tests consistent across comments,
> spaces, new lines and using count(*) >= 1 for all successful function
> executions. Thoughts?

Mostly OK by me, so applied after tweaking a few tiny things.  The
rewrites of the queries where we should have more than one record and
the removal of count() for the failure cases have been kept as
proposed, as are most of the comments.
--
Michael

Commits

  1. Improve a bit the tests of pg_walinspect

  2. Tweak regression test of pg_walinspect to be less collation-sensitive

  3. Rework design of functions in pg_walinspect

  4. Refactor and improve tests of pg_walinspect

  5. doc: Fix description of pg_get_wal_stats_till_end_of_wal() in pg_walinspect