Re: Generate pg_stat_get_xact*() functions with Macros
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: "Gregory Stark (as CFM)" <stark.cfm@gmail.com>, Andres Freund <andres@anarazel.de>, Michael Paquier <michael.paquier@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-03-25T02:50:50Z
Lists: pgsql-hackers
On Fri, Mar 24, 2023 at 06:58:30AM +0100, Drouvot, Bertrand wrote: > - Does not include the refactoring for pg_stat_get_xact_tuples_inserted(), > pg_stat_get_xact_tuples_updated() and pg_stat_get_xact_tuples_deleted() (as > they depend of [2] mentioned above) > > - Does not include the refactoring for > pg_stat_get_xact_function_total_time(), > pg_stat_get_xact_function_self_time(), > pg_stat_get_function_total_time() and > pg_stat_get_function_self_time(). I think they can be done in a > dedicated commit once we agree on the renaming for > PG_STAT_GET_DBENTRY_FLOAT8 (see Andres's comment up-thread) so that > the new macros can match the future agreement. > > - Does include the refactoring of the new > - pg_stat_get_xact_tuples_newpage_updated() function (added in > - ae4fdde135) Fine by me. One step is better than no steps, and this helps: 1 file changed, 29 insertions(+), 97 deletions(-) I'll go apply that if there are no objections. -- Michael
Commits
-
Generate a few more functions of pgstatfuncs.c with macros
- 4efd0bf7eaeb 16.0 landed
-
Generate pg_stat_get_xact*() functions for relations using macros
- 850f4b4c8cab 16.0 landed