Horton

Re: Normalization of utility queries in pg_stat_statements

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-03-08T06:19:33Z
Lists: pgsql-hackers

Attachments

On Fri, Mar 03, 2023 at 09:37:27AM +0900, Michael Paquier wrote:
> Thanks for double-checking, applied 0001 to finish this part of the
> work.  I am attaching the remaining bits as of the attached, combined
> into a single patch.

Doing so as a single patch was not feeling right as this actually
fixes issues with the location calculations for the Const node, so I
have split that into three commits and finally applied the whole.

As a bonus, please see attached a patch to apply the normalization to
CALL statements using the new automated infrastructure.  OUT
parameters can be passed to a procedure, hence I guess that these had
better be silenced as well.  This is not aimed at being integrated,
just for reference.
--
Michael

Commits

  1. Reflect normalization of query strings for utilities in pg_stat_statements

  2. Refine query jumbling handling for CallStmt

  3. Ignore IntoClause.viewQuery in query jumbling

  4. Improve cleanup phases in regression tests of pg_stat_statements

  5. Refactor more the regression tests of pg_stat_statements

  6. doc: Update pg_stat_statements about query ID calculation of utilities

  7. Expand regression tests of pg_stat_statements for utility queries

  8. Refactor tests of pg_stat_statements for planning, utility and level tracking