Re: add PROCESS_MAIN to VACUUM
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, pgsql-hackers@postgresql.org
Date: 2023-03-06T07:51:46Z
Lists: pgsql-hackers
On Wed, Mar 01, 2023 at 10:53:59PM -0800, Nathan Bossart wrote: > I don't feel a strong need for that, especially now that we aren't > modifying params anymore. That was mostly OK for me, so applied after tweaking a couple of places in the tests (extra explanations, for one), the comments and the code. The part that improved the tests of PROCESS_TOAST was useful on its own, so I have done that separately as 46d490a. Another thing that I have found incorrect is the need for two pg_stat_reset() calls that would reflect on the whole database, in the middle of a test running in parallel of other things. As far as I understand, you have added that to provide fresh data after a single command while relying on vactst, but it is possible to get the same amount of coverage by relying on cumulated counts, and that gets even more solid with all these commands run on an independent table. -- Michael
Commits
-
Improve readability of code PROCESS_MAIN in vacuum_rel()
- ee56048b0ecf 16.0 landed
-
Add PROCESS_MAIN to VACUUM
- 4211fbd8413b 16.0 landed
-
Improve the regression tests of VACUUM (PROCESS_TOAST)
- 46d490ac19a7 16.0 landed
-
Display the leader apply worker's PID for parallel apply workers.
- d540a02a724b 16.0 cited