Re: Ignore 2PC transaction GIDs in query jumbling

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Julien Rouhaud <rjuju123@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-08-27T08:32:25Z
Lists: pgsql-hackers
On Sat, Aug 19, 2023 at 01:47:48PM +0900, Michael Paquier wrote:
> On Fri, Aug 18, 2023 at 11:31:03AM +0100, Dagfinn Ilmari Mannsåker wrote:
>> I don't have a particularly strong opinion on whether we should
>> distinguish DEALLOCATE ALL from DEALLOCATE <stmt> (call it +0.5), but
> 
> The difference looks important to me, especially for monitoring.

After thinking a few days about it, I'd rather still make the
difference between both, so applied this way.

> And pgbouncer may also use both of them, actually?  (Somebody, please
> correct me here if necessary.)

I cannot see any signs of that in pgbouncer, btw.
--
Michael

Commits

  1. Show names of DEALLOCATE as constants in pg_stat_statements

  2. Show GIDs of two-phase commit commands as constants in pg_stat_statements