Horton

Re: Wrong usage of pqMsg_Close message code?

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: pavel.stehule@gmail.com, aleksander@timescale.com, pgsql-hackers@lists.postgresql.org
Date: 2023-08-28T22:53:37Z
Lists: pgsql-hackers 
On Tue, Aug 29, 2023 at 06:12:00AM +0900, Tatsuo Ishii wrote:
> I think EndReplicationCommand needs to be fixed as well.

Yeah, both of you are right here.  Anyway, it seems to me that there
is a bit more going on in protocol.h.  I have noticed two more things
that are incorrect:
- HandleParallelMessage is missing a message for 'P', but I think that
we should have a code for it as well as part of the parallel query
protocol.
- PqMsg_Terminate can be sent by the frontend *and* the backend, see
fe-connect.c and parallel.c.  However, protocol.h documents it as a
frontend-only code.
--
Michael

Commits

  1. Fix misuse of PqMsg_Close.