Horton

Re: Tidy recent code bloat in pg_creatersubscriber::cleanup_objects_atexit

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-16T11:09:36Z
Lists: pgsql-hackers 
On Tue, Mar 11, 2025 at 04:06:14PM +0900, Michael Paquier wrote:
> Right.  This improves the clarity of the code, so agreed about the use
> of a local variable here.

More code paths of pg_createsubscriber.c have similar loops, but this
is the only one where LogicalRepInfo can be used.  So, applied as you
have suggested, without touching the other loops.
--
Michael

Commits

  1. pg_createsubscriber: Remove some code bloat in the atexit() callback

  2. Add two-phase option in pg_createsubscriber.