Horton
Menu

Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string

Nathan Bossart <nathandbossart@gmail.com>

View thread
From: Nathan Bossart <nathandbossart@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, tharakan@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2025-03-12T19:03:04Z
Lists: pgsql-bugs 
On Tue, Mar 11, 2025 at 03:34:18PM -0700, Masahiko Sawada wrote:
> Pushed.

I'm seeing warnings for the CI build on Windows [0] that appear to be
related to this commit:

	c:\cirrus\contrib\pg_logicalinspect\pg_logicalinspect.c(88) : warning C4715: 'parse_snapshot_filename': not all control paths return a value

I suspect we just need to do something like commit fe4ecd0 and return
InvalidXLogRecPtr after the ERROR.

[0] https://api.cirrus-ci.com/v1/task/4876492255002624/logs/build.log

-- 
nathan

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_logicalinspect: Fix possible crash when passing a directory path.

  2. Add contrib/pg_logicalinspect.

  3. Fix compiler warning on Windows.