Re: Fix 035_standby_logical_decoding.pl race conditions
Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-21T16:18:02Z
Lists: pgsql-hackers
Hi Kuroda-san, On Fri, Mar 21, 2025 at 12:28:10PM +0000, Hayato Kuroda (Fujitsu) wrote: > I'm also working on the thread to resolve the random failure. Thanks for looking at it! > I've also tried the idea with the living transaction via background_psql(), > but I got the same result. The test could fail when RUNNING_XACTS record was > generated before the transaction starts. and thanks for testing and confirming too. > SIGSTOP signal for pg_recvlogical may do the idea, Yeah, but would we be "really" testing an "active" slot? At the end we want to produce an invalidation that may or not happen on a real environment. The corner case is in the test, not an issue of the feature to fix. So, I'm not sure I like the idea that much, but thinking out loud: I wonder if we could bypass the "active" slot checks in 16 and 17 and use injection points as proposed as of 18 (as we need the injection points changes proposed in 0001 up-thread). Thoughts? Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
Commits
-
Stabilize 035_standby_logical_decoding.pl.
- 105b2cb33617 18.0 landed
- 17a165d60f73 17.5 landed
- 86392e8827d8 16.9 landed