Re: Add contrib/pg_logicalsnapinspect

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

To: Masahiko Sawada <sawada.mshk@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Amit Kapila <amit.kapila16@gmail.com>, Andres Freund <andres@anarazel.de>, Peter Smith <smithpb2250@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, shveta malik <shveta.malik@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2025-03-06T08:34:23Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix indentation issue
- b955df443405 18.0 cited
pg_logicalinspect: Stabilize isolation tests.
- a49927f04cd0 18.0 landed
Add contrib/pg_logicalinspect.
- 7cdfeee320e7 18.0 landed
Move SnapBuild and SnapBuildOnDisk structs to snapshot_internal.h.
- e2fd615ecc17 18.0 landed

Hi,

On Wed, Mar 05, 2025 at 11:28:23PM -0800, Masahiko Sawada wrote:
> On Wed, Mar 5, 2025 at 3:10 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes:
> > > yeah makes sense. Done in the attached, and bonus point I realized that the
> > > test could be simplified (so, removing useless steps in passing).
> >
> > Just a side note: tayra showed two instances of this failure today
> > [1][2].  That's not using valgrind.

Thanks for the report!

> I wonder if we changed something
> > else recently that would make this more probable?
> >
> 
> I've observed the third failure.

I also did a "slow" test with the code tree at 7cdfeee320e and I can observe
the same "issue".

> I'm not sure
> what caused tayra to be slower overall recently.

yeah, tayra being slower is what make the test failure more probable. I'm also
not sure as to why.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com