Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread

From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

To: Masahiko Sawada <sawada.mshk@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, tharakan@gmail.com, pgsql-bugs@lists.postgresql.org

Date: 2025-03-05T06:44:16Z

Lists: pgsql-bugs

Attachments

v5-0001-Fix-bug-in-pg_logicalinspect-functions.patch (text/x-diff)

Hi,

On Tue, Mar 04, 2025 at 09:45:54PM +0000, Bertrand Drouvot wrote:
> Indeed, thanks for looking at it! Fixed in v4 attached. Note that the pfree()
> in parse_snapshot_filename() is not needed per say because the function is 
> currently executed in a short-lived memory context. It's there for safety reason
> in case it's called outside those SQL apis in the future.

After sleeping on it, PFA a simplified version.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pg_logicalinspect: Fix possible crash when passing a directory path.
- bd65cb3cd48a 18.0 landed
Add contrib/pg_logicalinspect.
- 7cdfeee320e7 18.0 cited
Fix compiler warning on Windows.
- fe4ecd08d81c 11.0 cited