Re: Add contrib/pg_logicalsnapinspect

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

To: Masahiko Sawada <sawada.mshk@gmail.com>

Cc: Andres Freund <andres@anarazel.de>, Peter Smith <smithpb2250@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, shveta malik <shveta.malik@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2025-03-05T07:17:09Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix indentation issue
- b955df443405 18.0 cited
pg_logicalinspect: Stabilize isolation tests.
- a49927f04cd0 18.0 landed
Add contrib/pg_logicalinspect.
- 7cdfeee320e7 18.0 landed
Move SnapBuild and SnapBuildOnDisk structs to snapshot_internal.h.
- e2fd615ecc17 18.0 landed

Attachments

v1-0001-Modify-pg_logicalinspect-isolation-test.patch (text/x-diff)

Hi,

On Tue, Mar 04, 2025 at 10:25:57PM -0800, Masahiko Sawada wrote:
> On Tue, Mar 4, 2025 at 1:56 PM Andres Freund <andres@anarazel.de> wrote:
> >
> Thank you for the report.

+1

> It seems that bgwriter wrote another RUNNING_XACTS record during the
> test, making the logical decoding write an extra snapshot on the disk.

Yup.

> One way to stabilize the regression test would be that we check if
> there is a serialized snapshot that has expected number of catchange
> transactions and number of committed transactions, instead of dumping
> all serialized snapshots.

Agree, PFA a patch doing so.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com