Horton

Re: Remove wal_[sync|write][_time] from pg_stat_wal and track_wal_io_timing

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-02-20T05:37:18Z
Lists: pgsql-hackers

Attachments

On Wed, Feb 19, 2025 at 09:24:41AM +0000, Bertrand Drouvot wrote:
> That's right but that would mean almost duplicating the pg_stat_wal related
> stuff (because it can't be removed from the doc until the fields are gone). I 
> think it's simpler to do it as proposed initially (the end result is the same).

After sleeping on it, I still saw no reason to not apply the changes
from 0002 in wal.sgml to describe that the stats for the writes/fsyncs
are in pg_stat_io rather than pg_stat_wal for the "WAL configuration"
section, so done that.  The tags were a bit inconsistent, and I've
managed to miss the.. cough.. s/sync_time/fsync_time/.

0001 was mixing a bit the tags <varname>, <literal> and <function>,
and I've moved that as a paragraph not under the tuning part, to make
it a more general statement with its link to "WAL configuration",
which is a very popular link for pg_stat_io.

Attached is the rest, as of v3-0002.
--
Michael

Commits

  1. Re-add GUC track_wal_io_timing

  2. Remove read/sync fields from pg_stat_wal and GUC track_wal_io_timing

  3. doc: Fix typo in section "WAL configuration"

  4. doc: Add details about object "wal" in pg_stat_io

  5. doc: Recommend pg_stat_io rather than pg_stat_wal in WAL configuration