Re: Inconsistent GUC descriptions

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>

Cc: pgsql-hackers@lists.postgresql.org

Date: 2025-02-18T05:42:36Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Make the description of some GUCs more consistent
- f2e4c2b2039e 18.0 landed

On Tue, Feb 18, 2025 at 10:32:40AM +0900, Kyotaro Horiguchi wrote:
> I found that a recent commit (fc069a3a631) introduced an inconsistent
> description for a new GUC variable, enable_self_join_elimination. It
> is written as "Enable removal of unique self-joins.", whereas similar
> variables use "Enables xxx". The attached first patch makes the
> message consistent with the typical wording.
> 
> While making this fix, I also noticed four other descriptions written
> as "Enable xxx". The attached second patch corrects them for
> consistency.

Keeping it simple..  I agree that your suggestions and your two
patches make things better, so OK for me.  There may be a point in
backpatching as this is user-visible?  Perhaps not.
--
Michael