Horton

Re: Move wal_buffers_full to WalUsage (and report it in pgss/explain)

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-02-17T06:18:04Z
Lists: pgsql-hackers 
On Fri, Feb 14, 2025 at 03:02:51PM +0900, Michael Paquier wrote:
> Not sure.  FWIW, it makes sense to me to group them by "family" in
> this case, as they would belong to the same instrument structure.

Looked at the full set again, and in the PGSS patch I have finished by
grouping all the WAL fields together, like we do for the rest.  In
EXPLAIN, we have other fields that use spaces rather than underscores,
see "actual time" for example, so I've done the same for buffers full.

Nothing much more to say, so I've applied the set.  Now let's see what
happens for the WAL stats patch at backend level.
--
Michael

Commits

  1. Add information about WAL buffers full to VACUUM/ANALYZE (VERBOSE)

  2. Add information about WAL buffers being full to EXPLAIN (WAL)

  3. pg_stat_statements: Add wal_buffers_full

  4. Move wal_buffers_full from PgStat_PendingWalStats to WalUsage

  5. pg_stat_statements: Add columns to track parallel worker activity