Horton
Menu

Re: Fix logging for invalid recovery timeline

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgbackrest.org>
Cc: Benoit Lobréau <benoit.lobreau@dalibo.com>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2025-02-24T22:33:08Z
Lists: pgsql-hackers 
On Mon, Feb 24, 2025 at 05:30:35PM +0000, David Steele wrote:
> +                                /* translator: %s is a backup_label or
> pg_control file */

See for example PostmasterMain() with the "/* translator: %s is a
configuration file */".

> +             errdetail("Latest checkpoint in %s is at %X/%X on timeline %u, but in
> the history of the requested timeline, the server forked off from that
> timeline at %X/%X.",
> +                     haveBackupLabel ? "backup_label" : "pg_control",

This part looks good to me.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve FATAL message for invalid TLI history at recovery

  2. Fix FATAL message for invalid recovery timeline at beginning of recovery