Horton
Menu

Re: Fix logging for invalid recovery timeline

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgbackrest.org>
Cc: Benoit Lobréau <benoit.lobreau@dalibo.com>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2025-02-24T01:05:26Z
Lists: pgsql-hackers 
On Sat, Feb 22, 2025 at 04:17:44PM +0000, David Steele wrote:
> I think for translation purposes this is probably how it needs to be but I
> wonder if we could do something like:
> 
> errdetail("Latest checkpoint in %s is at %X/%X <...>",
>           haveBackupLabel ? "pg_control" ? "backup_label",
> 
> I'll defer to Michael on that.

I think that you have the right idea here, avoiding the duplication
of the errdetail() which feels itchy when looking at the patch.  This
should have a note for translators that this field refers to a file
name.  The point is that we don't lose any context if we do a "control
file" => pg_control update in the errdetail().

This would also make the proposed patch simpler.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve FATAL message for invalid TLI history at recovery

  2. Fix FATAL message for invalid recovery timeline at beginning of recovery