Horton

Re: Fix for Extra Parenthesis in pgbench progress message

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Fujii Masao <masao.fujii@oss.nttdata.com>, Tatsuo Ishii <ishii@postgresql.org>, pgsql-release@lists.postgresql.org, pgsql-hackers@postgresql.org
Date: 2025-02-07T18:13:37Z
Lists: pgsql-hackers 
On Fri, Feb 07, 2025 at 01:10:04PM -0500, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> Oops, I was already taking a look at this.  I figured it'd just be
>> something like the following, although maybe there's a more elegant way.
> 
> Well, the stuff with prev_chars really ought to be skipped as well.
> (Yeah, it's probably a no-op, but readers shouldn't have to figure
> that out.)
> 
> My thought was that duplicating the logic isn't so bad, as attached.

WFM!

-- 
nathan

Commits

  1. Fix pgbench performance issue induced by commit af35fe501.

  2. pgbench: Ensure previous progress message is fully cleared when updating.