Re: Show WAL write and fsync stats in pg_stat_io

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Nazir Bilal Yavuz <byavuz81@gmail.com>

Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Melanie Plageman <melanieplageman@gmail.com>, Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>, "bharath.rupireddyforpostgres@gmail.com" <bharath.rupireddyforpostgres@gmail.com>, Thomas Munro <thomas.munro@gmail.com>

Date: 2025-02-07T00:47:53Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix copy-paste error related to the autovacuum launcher in pgstat_io.c
- 17d8bba6dad1 18.0 landed
Move SQL tests of pg_stat_io for WAL data to recovery test 029_stats_restart
- 428fadb7e97e 18.0 landed
Add data for WAL in pg_stat_io and backend statistics
- a051e71e28a1 18.0 landed
Improve comment on top of pgstat_count_io_op_time()
- b998fedab74c 18.0 landed
Refactor pgstat_prepare_io_time() with an input argument instead of a GUC
- 3c9d9acae0bc 17.0 landed

On Thu, Feb 06, 2025 at 03:39:05PM +0300, Nazir Bilal Yavuz wrote:
> My vote goes to 029. It already has the '## check checkpoint and wal
> stats are incremented due to restart' part and what we are adding is
> similar to that.

Okay, sold, with a routine grabbing some stats from pg_stat_io based
on an object, a context and a backend type to match with the style of
the test.  The stats are checked just after initialization, which
should be enough for our purpose.
--
Michael