Re: Show WAL write and fsync stats in pg_stat_io

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nazir Bilal Yavuz <byavuz81@gmail.com>, Melanie Plageman <melanieplageman@gmail.com>, Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>, "bharath.rupireddyforpostgres@gmail.com" <bharath.rupireddyforpostgres@gmail.com>, Thomas Munro <thomas.munro@gmail.com>

Date: 2025-02-06T08:39:25Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix copy-paste error related to the autovacuum launcher in pgstat_io.c
- 17d8bba6dad1 18.0 landed
Move SQL tests of pg_stat_io for WAL data to recovery test 029_stats_restart
- 428fadb7e97e 18.0 landed
Add data for WAL in pg_stat_io and backend statistics
- a051e71e28a1 18.0 landed
Improve comment on top of pgstat_count_io_op_time()
- b998fedab74c 18.0 landed
Refactor pgstat_prepare_io_time() with an input argument instead of a GUC
- 3c9d9acae0bc 17.0 landed

On Thu, Feb 06, 2025 at 07:32:01AM +0000, Bertrand Drouvot wrote:
> That sounds ok, but I wonder if that's the best appropriate place. I could
> think of the checkpointer test in 029_stats_restart.pl and the startup/standby
> one in one related to standby (030_stats_cleanup_replica.pl?). Though that's
> probably just a matter of taste.

Hmm.  Your suggestion of 029_stats_restart.pl is a tempting choice,
indeed, more in line with the fact that we are checking some stats
data.  I did not think about that.

Note that I'm OK about using 029 or even 030, as long as both queries
stay together.
--
Michael