Horton

add missing PQfinish() calls to vacuumdb

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Date: 2025-02-04T16:30:58Z
Lists: pgsql-hackers

Attachments

I noticed that vacuum_one_database() doesn't call PQfinish() before
pg_fatal() in a few of the server version checks.  I seem to have
unintentionally established this precedent in commit 00d1e88.  Michael
claimed to have fixed it before committing [0], but that seems to have been
missed, too.  I don't think this is a huge problem, but it does seem nicer
to properly close the connection before exiting.  If there are no
objections, I plan to commit and back-patch the attached patch shortly.

[0] https://postgr.es/m/20190108020300.GH22498%40paquier.xyz

-- 
nathan

Commits

  1. vacuumdb: Add missing PQfinish() calls to vacuum_one_database().

  2. Add --min-xid-age and --min-mxid-age options to vacuumdb