Horton

Re: Move wal_buffers_full to WalUsage (and report it in pgss/explain)

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-02-14T06:02:51Z
Lists: pgsql-hackers 
On Tue, Feb 11, 2025 at 02:05:18PM +0000, Bertrand Drouvot wrote:
>> 2. I have a small suggestion for pg_stat_statements: would it make sense to
>> move wal_buffers_full next to wal_records, wal_fpi and wal_bytes? This way,
>> all WAL-related information would be grouped together.
> 
> I think I prefer to add it in "append" order. That way, that does not break
> queries that rely on ordinal numbers.

Not sure.  FWIW, it makes sense to me to group them by "family" in
this case, as they would belong to the same instrument structure.
--
Michael

Commits

  1. Add information about WAL buffers full to VACUUM/ANALYZE (VERBOSE)

  2. Add information about WAL buffers being full to EXPLAIN (WAL)

  3. pg_stat_statements: Add wal_buffers_full

  4. Move wal_buffers_full from PgStat_PendingWalStats to WalUsage

  5. pg_stat_statements: Add columns to track parallel worker activity