Horton

Re: [PATCH] Optionally record Plan IDs to track plan changes for a query

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Lukas Fittl <lukas@fittl.com>
Cc: Sami Imseih <samimseih@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Marko M <marko@pganalyze.com>
Date: 2025-01-31T05:33:14Z
Lists: pgsql-hackers 
On Thu, Jan 30, 2025 at 09:19:49PM -0800, Lukas Fittl wrote:
> I'd be happy to tackle that - were you thinking to simply move any comments
> before the field, in each case where we're adding an annotation?

Yes.

> Separately I've been thinking how we could best have a discussion/review on
> whether the jumbling of specific plan struct fields is correct. I was
> thinking maybe a quick wiki page could be helpful, noting why to jumble/not
> jumble certain fields?

Makes sense.  This is a complicated topic.
--
Michael

Commits

  1. doc: Update header file mention for CompareType

  2. Allow plugins to set a 64-bit plan identifier in PlannedStmt

  3. Fix indentation of comment in plannodes.h

  4. Reformat node comments in plannodes.h

  5. injection_points: Add routine able to drop all stats

  6. Add pgstat_drop_matching_entries() to pgstats

  7. Move pg_stat_statements query jumbling to core.