Horton

Re: per backend I/O statistics

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-01-03T10:48:41Z
Lists: pgsql-hackers 
Hi,

On Tue, Dec 24, 2024 at 02:35:16PM +0900, Michael Paquier wrote:
> On Fri, Dec 20, 2024 at 09:57:19AM +0000, Bertrand Drouvot wrote:
> > BTW, now that the per backend I/O statistics is done, I'll start working on per
> > backend wal statistics.
> 
> I think that this is a good idea.

Thanks for sharing your thoughts.

> It does not actually overlap the
> proposal in [1] as the stats persistency is not the same.  What this
> thread has taught me is that you could just plug in the stats of the
> new backend-level structure a PgStat_WalStats and retrieve them with a
> new function that returns a single tuple with the WAL stats
> attributes.  That should be rather straight-forward to achieve.

I started to look at it and should be able to share a patch next week.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Rework handling of pending data for backend statistics

  2. Rename some pgstats callbacks related to flush of entries

  3. Relax regression test for fsync check of backend-level stats

  4. Add backend-level statistics to pgstats

  5. Extract logic filling pg_stat_get_io()'s tuplestore into its own routine

  6. Tweak some comments related to variable-numbered stats in pgstat.c