Re: Converting contrib SQL functions to new style

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Noah Misch <noah@leadboat.com>

Cc: Ronan Dunklau <ronan.dunklau@aiven.io>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>

Date: 2025-01-08T04:18:36Z

Lists: pgsql-hackers

On Tue, Jan 07, 2025 at 06:52:33PM -0800, Noah Misch wrote:
> It's more optimal to write '0'::bigint.  That generates a CONST node, whereas
> 0::bigint generates a FUNCEXPR calling the cast function.  No other concerns.

Makes sense, done this way.
--
Michael

Commits

Use @extschema:name@ notation in contrib transform modules.
- bebe9040388b 18.0 landed
pg_freespacemap: Fix declaration of pg_freespace(regclass)
- e0c3d5122e6a 18.0 landed
contrib/pageinspect: Use SQL-standard function bodies.
- 68ff25eef125 18.0 landed
contrib/xml2: Use SQL-standard function bodies.
- 667368fd26de 18.0 landed
contrib/citext: Use SQL-standard function bodies.
- 97a5a16849eb 18.0 landed
contrib/earthdistance: Use SQL-standard function bodies.
- 969bbd0fafc0 18.0 landed
- 3652de36e432 17.3 landed
- 31daa10facec 16.7 landed
contrib/lo: Use SQL-standard function bodies
- 13e3796c906b 18.0 landed
xml2: Add tests for functions xpath_nodeset() and xpath_list()
- 93f9b4a93fef 18.0 landed
contrib/lo: Add test for function lo_oid()
- 3ef038fc4f76 18.0 landed
pg_freespacemap: Use SQL-standard function bodies
- 3f323eba89fb 18.0 landed
Add @extschema:name@ and no_relocate options to extensions.
- 72a5b1fc8804 16.0 cited
Make contrib modules' installation scripts more secure.
- 7eeb1d9861b0 14.0 cited